]> dgit.raspbian.org Git - gnome-shell.git/commit
signalTracker: Don't try to create a new SignalTracker for disconnecting
authorSebastian Keller <skeller@gnome.org>
Mon, 29 Aug 2022 02:19:28 +0000 (04:19 +0200)
committerMarge Bot <marge-bot@gnome.org>
Sat, 3 Sep 2022 15:11:46 +0000 (15:11 +0000)
commit54ee728aa088f12cfb67e006cf75d9bbe5964b7a
tree28e6ac4316859473d4dcf724312da40a242c56ff
parentd57953ad94ef8b58bb37c5d1fc9e6a34f30778ed
signalTracker: Don't try to create a new SignalTracker for disconnecting

After the next commit, when some classes, such as PopupMenuManager try
to disconnect via a destroy handler, the SignalTracker might have
already been destroyed, so trying to get it from the SignalManager will
cause it to create a new one, which will then try to connect to the
destroy signal of the already destroyed object.

This could for example be triggered by changing backgrounds.

Fix this by not doing anything in disconnectObject if there is no
SignalTracker for that object.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2466>
js/misc/signalTracker.js